refactor: only prevent mousedown on mobile if input has focus #10270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I tried the branch on my iPhone, and the reported issue appears quite rarely. I wasn't able to define which steps are required to reproduce it. |
web-padawan
force-pushed
the
refactor/clear-button-mousedown-mobile
branch
from
2e3b806 to
6d8831c
Compare
Member
Author
|
Added missing logic to the date-picker to ensure |
|
DiegoCardoso
approved these changes
Oct 27, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 28, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 28, 2025
web-padawan
added a commit
that referenced
this pull request
Oct 28, 2025
#10394) Co-authored-by: Serhii Kulykov <[email protected]>
web-padawan
added a commit
that referenced
this pull request
Oct 28, 2025
#10395) Co-authored-by: Serhii Kulykov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10149
Type of change
Note
There was a problem with testing on iOS device, see recording below:
ScreenRecording_09-25-2025.12-55-21_1.MP4